dedupe windowed libraries at the end#5482
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Modified compiler to deduplicate window libraries before template rendering in reflex/compiler/compiler.py, using list comprehension with index comparison.
- Added deduplication logic in
_compile_appfunction using O(n²) index comparison approach - Implementation choice uses simple list comprehension since window library lists are typically short
- Note: Performance impact negligible for current use case but could be optimized if list sizes grow
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
CodSpeed Performance ReportMerging #5482 will not alter performanceComparing Summary
|
Lendemor
approved these changes
Jun 20, 2025
masenf
pushed a commit
that referenced
this pull request
Jun 26, 2025
* dedupe windowed libraries at the end * use list dict fromkeys Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm using index == index because the list is typically short